tickets/SP-2741: use observation_reason as default field to map to color in some plots#191
Merged
tickets/SP-2741: use observation_reason as default field to map to color in some plots#191
Conversation
ehneilsen
force-pushed
the
tickets/SP-2741
branch
from
947ebe8 to
7fbfe4e
Compare
ehneilsen
force-pushed
the
tickets/SP-2741
branch
from
7fbfe4e to
22e0726
Compare
Member
|
I think using the bandpass for the color and the observation reason for the shape is the new thing, but certainly using scheduler_note rather than observation_reason will be tricky (especially as we add indexes to all of the scheduler notes, since that's useful). So will approve, and then we do another update? |
rhiannonlynne
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following lsst/rubin_scheduler#236 (comment)